RE: [PATCH] Fix memory leaks in ident.cc

The same can be said for the existing ClientAdd() and identCallBack() definitions. I just followed what was already there. Mike Mitchell ________________________________________ From: Alex Rousskov [rousskov_at_measurement-factory.com] Sent: Friday, December 21, 2012 2:07 PM To: Mike Mitchell Cc: squid-dev_at_squid-cache.org Subject: Re: [PATCH] Fix memory leaks in ident.cc On 12/21/2012 11:06 AM, Mike Mitchell wrote: > The attached patch plugs a memory leak in ident.cc. > The IdentStateData structure was not freed if the ident request failed. I have not reviewed the functional changes in the patch, but the Ident::Close_() definition is missing a "static" keyword that is present in the Ident::Close_() declaration. IIRC, this will generate warnings with some compilers. Thank you, Alex.
Received on Fri Dec 21 2012 - 19:55:19 MST