Re: [PATCH] Fix memory leaks in ident.cc

On 12/21/2012 11:06 AM, Mike Mitchell wrote:
> The attached patch plugs a memory leak in ident.cc.
> The IdentStateData structure was not freed if the ident request failed.

I have not reviewed the functional changes in the patch, but the
Ident::Close_() definition is missing a "static" keyword that is present
in the Ident::Close_() declaration. IIRC, this will generate warnings
with some compilers.

Thank you,

Alex.
Received on Fri Dec 21 2012 - 19:07:21 MST