Re: forwarded_for documentation inaccurate

Alex Rousskov wrote:
> On Wed, 2008-01-30 at 09:42 +1100, Mark Nottingham wrote:
>
>> My experience has been that if I just file a bug, nobody notices,
>> while if I bring it up here, people tend to pay attention... Perhaps
>> if I file a bug and then bring it to the list's attention?
>
> I can only speak for myself: If I see a Squid3 bug here, I will most
> likely forget about it. If there is a Squid3 bug in bugzilla, and it is
> relevant to the projects I work on, I will either fix it or ask somebody
> to fix it, eventually. Relevant bugzilla bugs bug me until they are
> gone :-).

Same, though I give more immediate short-term attention to those sent
here also. Seeing as they may be forgotten later or shifted
'temporarily' into the long-term todo folder.

>
> My filter files bugzilla and squid-dev emails together, so there is no
> difference as far as "getting noticed" is concerned. I am sure it is
> different for other developers though.

Would be nice if I could get bugzilla emails too, but I work around that
with an extensive set of bugzilla bookmarks.

>
> Thanks again for reporting this and many other bugs!
>
> Alex
>

Seconded.

Amos

>
>> On 30/01/2008, at 5:32 AM, Alex Rousskov wrote:
>>
>>> On Tue, 2008-01-29 at 15:29 +1100, Mark Nottingham wrote:
>>>> if cf.data.pre:
>>>>
>>>>> NAME: forwarded_for
>>>>> COMMENT: on|off
>>>>> TYPE: onoff
>>>>> DEFAULT: on
>>>>> LOC: opt_forwarded_for
>>>>> DOC_START
>>>>> If set, Squid will include your system's IP address or name
>>>>> in the HTTP requests it forwards. By default it looks like
>>>>> this:
>>>>>
>>>>> X-Forwarded-For: 192.1.2.3
>>>>>
>>>>> If you disable this, it will appear as
>>>>>
>>>>> X-Forwarded-For: unknown
>>>>> DOC_END
>>>> 1) s/your system's/clients'/
>>>>
>>>> 2) If you disable this, the x-forwarded-for header won't be added/
>>>> modified.
>>> Hi Mark,
>>>
>>> If possible, please file bugs like this with bugzilla. It may seem
>>> like there is not much of a difference, and sometimes there is not,
>>> but
>>> Bugzilla entries make life so much easier for those of us who want to
>>> help but cannot immediately rush in and fix the bug.
>>>
>>> This bug is now http://www.squid-cache.org/bugs/show_bug.cgi?id=2205
>>>
>>> Thank you,
>>>
>>> Alex.
>>>
>>>
>> --
>> Mark Nottingham mnot@yahoo-inc.com
>>
>

-- 
Please use Squid 2.6STABLE17+ or 3.0STABLE1+
There are serious security advisories out on all earlier releases.