Re: MAGIC1 in src/fs/aufs/store_asyncufs.h

From: Henrik Nordstrom <hno@dont-contact.us>
Date: Mon, 4 Aug 2003 23:50:06 +0200

On Monday 04 August 2003 19.31, Duane Wessels wrote:

> It seems wrong to me that MAGIC1 is proportional to the SQUARE of
> the number of cache_dir's. I could even argue that it should be
> logarithmic since performance doesn't really scale linearly with
> #disks or cache_dirs.

Indeed.

> Also I would suggest that these calculations use the number
> of AUFS cache_dirs, which might be less than the total number.
> Kind of hard to put that in a #define though.

Not really. The aufs stores are all initialized when this is used. All
we need is to make aufs keep memory of how many directories it has
and use that instead of the global Config.cacheSwap.n_configured. In
fact we even have such variable already..

Fixing up...

Regards
Henrik
Received on Mon Aug 04 2003 - 15:50:45 MDT

This archive was generated by hypermail pre-2.1.9 : Tue Dec 09 2003 - 16:20:26 MST