Re: Fwd: Squid ICAP client problems

Hello Henrik,

on Mon, 09 Jun 2003, Henrik Nordstrom wrote:

> -----Original Message-----
> From: Rosenbaum, Larry M.
> Sent: Thursday, June 05, 2003 12:57 PM
> To: 'geetha.manjunath@hp.com'; 'ralf.horstmann@webwasher.com'
> Subject: Squid ICAP client problems

[...]

> 2) (cache_cf.c) If you don't have a "icap_class" line in the config
> file, squid will crash if you do a "-k reconfigure". This is because
> the class structure has an element with a null iter->name. Here is
> one possible fix:

I think the real problem is that some pointers are not reset properly.
Here is a patch:

diff -u -r1.38.6.11.2.2 cache_cf.c
--- cache_cf.c 7 Apr 2003 13:28:50 -0000 1.38.6.11.2.2
+++ cache_cf.c 10 Jun 2003 09:03:00 -0000
@@ -2145,6 +2145,7 @@
            cbdataFree(current_node);
            current_node = next_node;
        }
+ cfg->service_head = NULL;
     }
 }
 
@@ -2381,6 +2382,7 @@
            memFree(current_node, MEM_ICAP_CLASS);
            current_node = next_node;
        }
+ cfg->class_head = NULL;
     }
 }
 
@@ -2553,6 +2555,7 @@
            memFree(current_node, MEM_ICAP_ACCESS);
            current_node = next_node;
        }
+ cfg->access_head = NULL;
     }
 }

Regards, Ralf.
Received on Tue Jun 10 2003 - 04:35:00 MDT