Re: move xrename function [PATCH]

On 13 Aug 2001 09:57:26 +0200, Guido Serassio wrote:
> Hi Robert,
>
> >
> >It uses a different call tree to rotate cache.log which results in
> >xrename being used. Could you see if it works for you?
>
> Can you check if pinger on external_logger branch link without errors ?
>
> The reason because i move xrename in debug.c, is that pinger is linked
> against debug.o, so may be there are some unresolved functions from logfile.c.

Why does pinger.exe call the log rotate function? Your linker shouldn't
need to resolve the symbols for non-used functions. Ah well. If it
doesn, it does.

Anyway, debug.c does not call any logfile.c functions, so you should be
quite safe linking pinger.exe. I'm developing almost 100% on linux, so
it'd be a lot easier for you to test for pinger.exe linking properly
under the external_logger branch than for me, but if you don't have time
I'll try to schedule it in for when I look into the cygwin 1.3.[2|3]
issue with squid.
 
> >It's a cleaner solution IMO.
>
> Yes, my only "resistance" come from the native WIN32 work: at this moment
> helper doesn't works at all.
> Andrey Shorin made this work on 2.3 STABLE 5, but with too much code
> changes in squid and helpers sources.

I have some notes if that'd help you. Mainly I found a
address-not-reachable being returned from winsock. *shrug*.

Rob
 
> Guido
>
> >Rob
> >
> > > Guido
> > >
> > >
> > >
> > > -
> > > =======================================================
> > > Serassio Guido
> > > Via Albenga, 11/4 10134 - Torino
> > - ITALY
> > > Tel. : +39.011.610749
> > > E-mail: serassio@interfree.it
> > > serassio@libero.it
> > > WWW: http://www.serassio.it
>
>
> -
> =======================================================
> Serassio Guido
> Via Albenga, 11/4 10134 - Torino - ITALY
> Tel. : +39.011.610749
> E-mail: serassio@interfree.it
> serassio@libero.it
> WWW: http://www.serassio.it
>
Received on Mon Aug 13 2001 - 05:38:03 MDT