Re: move xrename function [PATCH]

Hi Robert,

Il 00.26 13/08/2001 Robert Collins ha scritto:
>On 12 Aug 2001 18:03:04 +0200, Guido Serassio wrote:
> > Hi,
> >
> > Attached there is a patch for HEAD to move the xrename function from
> > tools.c to debug.c.
> >
> > This because i need on WIN32 to use xrename instead rename on debug.c and
> > this is the only code re-arrangement without link problems.
> >
> > There was a little thread on squid-dev about this on May.
> >
> > The patch file is generated against HEAD branch on SourceForge and was
> > tested on Cygwin and Linux.
> >
> > Could someone please commit this to HEAD ?
>
>Uhmm, before we do this, could you try the external_logger branch for
>me?
>
>It uses a different call tree to rotate cache.log which results in
>xrename being used. Could you see if it works for you?

Can you check if pinger on external_logger branch link without errors ?

The reason because i move xrename in debug.c, is that pinger is linked
against debug.o, so may be there are some unresolved functions from logfile.c.

>It's a cleaner solution IMO.

Yes, my only "resistance" come from the native WIN32 work: at this moment
helper doesn't works at all.
Andrey Shorin made this work on 2.3 STABLE 5, but with too much code
changes in squid and helpers sources.

Guido

>Rob
>
> > Guido
> >
> >
> >
> > -
> > =======================================================
> > Serassio Guido
> > Via Albenga, 11/4 10134 - Torino
> - ITALY
> > Tel. : +39.011.610749
> > E-mail: serassio@interfree.it
> > serassio@libero.it
> > WWW: http://www.serassio.it

-
=======================================================
Serassio Guido
Via Albenga, 11/4 10134 - Torino - ITALY
Tel. : +39.011.610749
E-mail: serassio@interfree.it
         serassio@libero.it
WWW: http://www.serassio.it
Received on Mon Aug 13 2001 - 01:57:34 MDT