Re: [squid-users] tcp_outgoing_tos doesn't work in 3.2?

From: Amos Jeffries <squid3_at_treenet.co.nz>
Date: Wed, 02 Jan 2013 13:15:54 +1300

On 2/01/2013 4:24 a.m., Andrew Beverley wrote:
> On Tue, 2013-01-01 at 15:15 +0000, Andrew Beverley wrote:
>> Therefore, could you please try the following (untested) patch?
> Ah, Amos, I've just re-read the bug report and seen that you have closed
> it with a FreeBSD workaround. I couldn't see your commit, but from what
> I have read it looks like FreeBSD definitely expects a TOS value as an
> int, so that should be the correct solution.

I patched the function internally to store the 8-bit tos_t parameter
into a local int before sending to setsockopt() on FreeBSD. That way we
still save on 3 bytes in all the Squid objects using it.

PS. I would still like to know if the problem occurs on other BSD
variants to extend the patch #if condition for them.

Amos
Received on Wed Jan 02 2013 - 00:16:02 MST

This archive was generated by hypermail 2.2.0 : Wed Jan 02 2013 - 12:00:03 MST