Re: [squid-users] Does Squid support ICAP/1.0 201 Created ?

Thanks Chris!

I actually made this change earlier this morning and
recompiled, etc.. and it's working quite nicely.
Although I feal much better about my workaround now
that it's been independently verified :) As far as I
can tell the 201 can be handled the same as a 200
since everything else about it is identical. Not sure
if this is true in the 'real world' but it seems to be
true enough for my purposes...

Thanks again, -Matt

--- Christos Tsantilas <christos@chtsanti.net> wrote:

> Hi Matt,
>
>
> >......
> >
> >Squid does not seem to handle this "ICAP/1.0 201
> >Created". Everything else about the responses are
> >identical, only this first line differs. I've
> checked
>
>
> Yes squid-icap does not handle "201 Created"
> responces....
>
> try the attached small patch, but be carefull I did
> not test it ...
>
>
> Regards,
> Christos
>
>
> > diff -u
>
/home/projects/squid/squid-icap-2.5-cvs/squid-icap-2_5/src/icap_reqmod.c
> ./icap_reqmod.c
> ---
>
/home/projects/squid/squid-icap-2.5-cvs/squid-icap-2_5/src/icap_reqmod.c
> 2005-04-25 23:31:40.000000000 +0300
> +++ ./icap_reqmod.c 2005-08-30 20:42:00.204306272
> +0300
> @@ -508,7 +508,7 @@
> comm_close(fd);
> return;
> };
> - if (200 != status) {
> + if (200 != status && 201 != status) {
> debug(81, 1) ("Unsupported status '%d' from ICAP
> server\n", status);
> icapEntryError(icap, ERR_ICAP_FAILURE,
> HTTP_INTERNAL_SERVER_ERROR,
> errno);
> diff -u
>
/home/projects/squid/squid-icap-2.5-cvs/squid-icap-2_5/src/icap_respmod.c
> ./icap_respmod.c
> ---
>
/home/projects/squid/squid-icap-2.5-cvs/squid-icap-2_5/src/icap_respmod.c
> 2005-05-17 07:49:47.000000000 +0300
> +++ ./icap_respmod.c 2005-08-30 20:39:44.736900448
> +0300
> @@ -510,7 +510,7 @@
> return;
> }
> #endif
> - if (200 != status) {
> + if (200 != status && 201 != status) {
> debug(81, 1) ("Unsupported status '%d' from ICAP
> server\n", status);
> /* Did not find a proper ICAP response */
> err = errorCon(ERR_ICAP_FAILURE,
> HTTP_INTERNAL_SERVER_ERROR);
>

                
____________________________________________________
Start your day with Yahoo! - make it your home page
http://www.yahoo.com/r/hs
 
Received on Tue Aug 30 2005 - 14:37:15 MDT