Re: Splaytree fixes in 2.2.STABLE4 [PATCH]

In article <3796B7FC.BDC75D7A@erl.sbs.de> you write:

>Changelog says, that there have been some fixes concerning the
>splay tree collision detection. Since 2.2.4 I get strange effects:
>For example:
>1999/07/21 23:04:04| WARNING: 6teen.com is a subdomain of 8teen.com
>1999/07/21 23:04:04| WARNING: This may break Splay tree searching
>1999/07/21 23:04:04| WARNING: You should remove '6teen.com' from the ACL
>named 'sexdomains'
>1999/07/21 23:04:04| WARNING: yteens.com is a subdomain of 8teens.com
>1999/07/21 23:04:04| WARNING: This may break Splay tree searching
>1999/07/21 23:04:04| WARNING: You should remove 'yteens.com' from the
>ACL named 'sexdomains'
>
>6teen.com is IMHO no subdomain for 8teen.com, or did I miss something ?

The aclDomainCompare function has been modified in STABLE4 but I'm not
sure it gives correct output. For example, when comparing two exactly
the same strings the result is -1 instead of 0!

I've had numerous troubles with the above warnings caused by overlaps in
my (quite big) access lists. And you only get the warnings for domain
based acls, but IP based acls have the same problem.

My first workaround was porting the linked list code from 1.1 to 2.X.
But I've been working for quite some time now on a structural solution
by eliminating overlapping entries from splay trees. Some time ago I
explained the details on this list.

The latest version of my patch for STABLE4 can be found at:

        http://www.iae.nl/users/devet/squid/

Please try it out if you can and let the list know if it works for you.

It would be nice if it could be integrated into STABLE5 such that acls
work correctly again even with overlapping entries.

Arjan

Cc: squid-bugs
Received on Thu Jul 22 1999 - 15:46:03 MDT