ftpget-1.1.8 / pasv => no route to host / patch

From: Laurent FACQ <facq@dont-contact.us>
Date: Thu, 6 Mar 1997 14:42:43 +0100 (MET)

        If you try this URL

                ftp://ftp.enst-bretagne.fr

        squid-1.1.8 will tell you "no route to host"

        but this ftp server works fine with traditional
        ftp client (no PASV)

        what happens is that this ftpd respond correctly
        to the PASV command, but when you try to connect
        to the indicated port... nothing... and squid take that
        as a "soft failure" and exit.

        i think we could change this behaviour saying "ok
        let's try PASV mode, and if something goes wrong
        fallback in usual mode (PORT)"

        here is the very small patch i propose :

*** src/ftpget.c Mon Mar 3 20:55:01 1997
--- src/ftpget.c Thu Mar 6 12:07:42 1997
***************
*** 1568,1574 ****
        sprintf(r->errmsg, "%s, port %d: %s", junk, port, xstrerror());
        r->rc = 2;
        pasv_supported = 0;
! return FAIL_SOFT;
      }
      r->dfd = sock;
      return PORT_OK;
--- 1568,1574 ----
        sprintf(r->errmsg, "%s, port %d: %s", junk, port, xstrerror());
        r->rc = 2;
        pasv_supported = 0;
! return PASV_FAIL;
      }
      r->dfd = sock;
      return PORT_OK;

        
        LF.

--
Laurent FACQ - facq@u-bordeaux.fr (05.56.84.65.34) - Reseau REAUMUR / Bordeaux
Received on Thu Mar 06 1997 - 05:52:39 MST

This archive was generated by hypermail pre-2.1.9 : Tue Dec 09 2003 - 16:34:38 MST