Re: [PATCH] cache_peer standby=N

On 30/04/2014 4:00 a.m., Tsantilas Christos wrote:
> To summarize, the requested changes are:
>
> *in cf.data.pre:
> replace:
> max-conn limit works poorly when there is a relatively
> large number of idle persistent connections with the
> peer because the limiting code does not know that
> Squid can often reuse some of those idle connections.
>
> with:
> max-conn currently works poorly with idle persistent connections: When a
> peer reaches its max-conn limit, and there are idle persistent
> connections to the peer, the peer may not be selected because the
> limiting code does not know whether Squid can reuse those idle connections.
>
>
> *n src/cache_cf.cc:
> please use "ERROR:" instead of "parse_peer:" in 'fatalf("parse_peer:'...
>
> * in pconn.h:
> document closeN as follows:
> /// closes any n connections, regardless of their destination
> void closeN(int n);
>
> * in neighbors.cc
> add the following comment at the beginning of peerDNSConfigure:
> // TODO: connections to no-longer valid IP addresses should be
> // closed when we can detect such IP addresses.
>
>
> Is it OK?
>

Yes. Since its all documentation I dont think it needs another review.

Amos
Received on Tue Apr 29 2014 - 17:48:29 MDT