Re: [PATCH 1/8] reconfiguration leaks: implicit ACLs

On 25/04/2014 12:46 p.m., Alex Rousskov wrote:
> Do not leak implicit ACLs during reconfigure.
>
> Many ACLs implicitly created by Squid when grouping multiple ACLs were
> not destroyed because those implicit ACLs where not covered by the
> global ACL registry used for ACL destruction.
>
> See also: r13210 which did not go far enough because it incorrectly
> assumed that all InnerNode() children are aclRegister()ed and, hence,
> will be centrally freed.
>
> Alex.
>

-0.

I believe we should move to reference counting ACLs instead of
continuing to work around these edge cases.

Amos
Received on Fri Apr 25 2014 - 07:58:48 MDT