Re: [PATCH] refactor Vector

From: Alex Rousskov <rousskov_at_measurement-factory.com>
Date: Mon, 10 Feb 2014 09:16:42 -0700

On 02/10/2014 02:20 AM, Kinkie wrote:
>> The kind of cast appears to be wrong here: Const_cast<> is normally used
>> to remove const, not add it. It is not used to change the type.
>
> It is currently a c-style cast.
> Attributes is built over push_back(), so the only way to cleanly make
> it const would be to copy it after it's built.
> Without it,
> CustomParser.cc:209:83: error: invalid conversion from 'char**' to
> 'const char**' [-fpermissive]

My bad: I did not realize the type before casting is char**.
Const_cast<> is the right thing to do here.

Alex.
Received on Mon Feb 10 2014 - 16:17:01 MST

This archive was generated by hypermail 2.2.0 : Mon Feb 10 2014 - 12:00:11 MST