Re: [PATCH] Fix leaks and check for newer libraries in Kerberos related helpers

On 23/09/2013 12:58 a.m., Markus Moeller wrote:
> Hi Amos,
>
> I did some cleanup. I think I moved all variables I could to sub
> scopes.
>
> Thank you
> Markus
>

This one looks much better thank you. Still some minor nits itching at
my perfectionist side but I can suppress that for now.

in helpers/negotiate_auth/kerberos/negotiate_kerberos_auth.cc:
* at the chunk for line 285 you still seem to have:
   if (spegnoToken)
     xfree(spegnoToken)

* same at line 485

in src/peer_proxy_negotiate_auth.cc:
* those defined() are still present.

If you want make a new patch or provide reasons for those please do.
Otherwise I will fix those and apply this patch after a good sleep.

FYI: I will also be running the source maintenance script on it to
cleanup large sections of weird whitespace alignment, so what appears in
trunk after the merge may clash with your copy.

Thank you

Amos
Received on Thu Sep 26 2013 - 17:05:00 MDT