Re: [PATCH] Unknown cfg function

On 08/01/2013 01:35 AM, Amos Jeffries wrote:
> On 31/07/2013 7:22 p.m., Tsantilas Christos wrote:
>> An opinion here.
>> Should the quoted-strings support enabled/disabled using the
>> configuration_includes_quoted_values on/off
>> configuration parameter, or do you believe that it should hardcoded in
>> realms parsing for example?

> I that would prevent the intentional update to quoted-values for that
> option.

Yes, it should not be hard-coded like that. Since strict syntax will not
be the default, old realms will work in legacy configurations while
allowing folks to upgrade to strict syntax when they are ready.

>> Or just implement a new ConfigParser::NextToEol() method for such cases?
>
> I think that making NextQuotedOrToEol() obey the RecognizeQuotedValues
> flag will solve all these cases. The behaviour changing when it is
> altered by the admin is not a big issue if we document it clearly which
> ones are affected.
> The problem here is more from changing the default behaviour silently,
> than from what it is changed to.

I think I agree with that. I hope my comprehensive list posted earlier
covers this case in a similar fashion.

Thank you,

Alex.
Received on Thu Aug 01 2013 - 16:51:45 MDT