Re: [PATCH] Polish the Consistency of Case Sensitivity in Configurations

On 17/02/2013 8:10 p.m., Tianyin Xu wrote:
> Hi, all,
>
> I proposed to make it consistent for the case sensitivity of
> configuration parsing couple weeks ago. I saw the replies from Alex,
> Reiner, and Amos. All of you agreed on this (thanks a lot!). The
> attached patch is for this purpose.
>
> The patch follows Alex's idea, i.e., to make all the parameter names
> and options case sensitive.
>
> The patch is really simple that changes "strcasecmp" to "strcmp". It
> mainly deal with constant configuration options (e.g., enumerative
> options and boolean options). For directive names, it's already
> consistent (case sensitive), as Amos said, the parser functions are
> auto-generated.
>
> I didn't change the case sensitivity of the following parameter values:
>
> - user and group names
> - host names
> - domain and realm names
> - ACL names
> - filesystem names
> - options in request/response/digest messages
>
> Some of them should be case insensitive, and some of them I cannot
> judge so I have to be conservative. If you want to make any of them
> case sensitive, please let me know.
>
> Let me know your comments and opinions about the patch. I'm always open.
>
> Thanks,
> Tianyin
>
>

+1.

Amos
Received on Mon Feb 18 2013 - 03:54:43 MST