Re: [PATCH] "address.GetPort() != 0" assertion for helpers on FreeBSD

On 01/10/2013 03:47 AM, Kinkie wrote:

> I second Amos' suggestion, +1 from me as well if it's followed.

Adjusted and committed to trunk as r12578.

Thank you,

Alex.

> On Thu, Jan 10, 2013 at 10:07 AM, Amos Jeffries <squid3_at_treenet.co.nz> wrote:
>> On 9/01/2013 6:13 p.m., Alex Rousskov wrote:
>>>
>>> Hello,
>>>
>>> Some v3.3 and trunk helpers are broken on FreeBSD and possibly some
>>> other non-Linux OSes. Squid using ssl_crtd, URL rewriter, and possibly
>>> other helpers asserts on startup:
>>>
>>> assertion failed: comm.cc:800: "address.GetPort() != 0"
>>>
>>> Our src/defines.h #include file requires sys/socket.h on FreeBSD for
>>> AF_UNIX to be defined in time for IPC_* tests. I suspect a similar but
>>> not-yet-exposed dependency exists for O_TEXT and friends.
>>>
>>> The attached patch fixes the AF_UNIX bug in my tests. A better long-term
>>> fix is welcomed.
>>
>>
>> +1.
>>
>> Although, since defines.h is one of the files we are trying to eradicate I'm
>> inclined to put the new #include right above the #if condition which is
>> depending on it so they get shuffled together when that shuffling happens.
>>
>> Amos
>
>
>
Received on Sat Jan 12 2013 - 18:32:15 MST