Re: [PATCH] Http::MethodType upgrade

On 07/23/2012 08:31 PM, Amos Jeffries wrote:

> * url.cc parsing switch cases used to split CONNECT are converted to
> if-else syntax
> - not a major change, but worth mentioning since it is logic alteration.

I see the switch/if change, but it is not clear to me what changed in
the processing logic itself. Perhaps the commit message can
document/explain that?

BTW, there seems to be quite a bit of duplicated snprintf()-related code
in those url.cc changes. Please factor it out if possible.

> HttpRequest class changes:
>
> - updated to cache the complex calculation result.

I think the maybeCacheable_ caching must be removed because it will
create problems similar to canonical URL caching: There is no code to
invalidate the cached value when related request properties change. And
the calculation is not that costly from CPU cycles point of view to
necessitate caching anyway.

> TODO: needs testing through co-advisor to check for RFC compliance
> regressions.

Please ping Dmitry (CCed) to organize this regression check when the
final patch version is available.

Thank you,

Alex.
Received on Tue Jul 24 2012 - 14:28:50 MDT