Re: [PATCH] Support bump-ssl-server-first and mimic SSL server certificates

On 19.07.2012 06:20, Tsantilas Christos wrote:
> The bump-server-first branch merged to trunk with revno: 12219
> Someone can examine the log messages of the bump-server-first branch
> using "bzr log --include-merges"
>
> I hope it is OK.
>
> On 07/17/2012 04:57 AM, Amos Jeffries wrote:
>> Are the new WARNING really that important that they always be at
>> CRITICAL level?
>> I would think the impact was a bit less (no impact in the case of
>> deny)
>> s/DBG_CRITICAL/DBG_PARSE_NOTE(2)/ for the deny conversion?
>> s/DBG_CRITICAL/DBG_PARSE_NOTE(DBG_IMPORTANT)/ for the allow
>> conversion?
>>
>> ... using the DBG_PARSE_NOTE(x) macro which is now available in
>> trunk,
>> it bumps the message up to CRITICAL when -k parse is used, but
>> outputs
>> at the indicated value during normal startup/reconfigure operations.
>
> Sorry Amos I forgot this one. I planned to make the fix after merging
> from trunk because the macro has recently added and did not included
> in
> bump-server-first branch. But after merged from trunk I forgot this
> change.
> BUT with a second look I think it is not a correct fix because we
> need
> to print "WARNING" and "SECURITY NOTICE" messages on normall
> startup/reconfigure and not only in "-k parse" case.
> In any case we can fix it as separate patch....

Okay. Not a big problem. We can fix it later if people complain about
the annoyance being too much.

Amos
Received on Wed Jul 18 2012 - 23:52:34 MDT