Patch applied to trunk as two separate patches (or better 3 because I
had forgot to do a "bzr add" the stub_libformat.cc file before commit):
- "Convert AccessLogEntry class to RefCountable" patch with revno:12212
- "Add request_header_add option" patches with revno: 12213, 12214
It took some time to fix "make check" and "make distcheck" in order to
work well in my machines. I hope it is OK now.
Christos
On 07/12/2012 02:47 AM, Amos Jeffries wrote:
> On 12.07.2012 06:49, Tsantilas Christos wrote:
>> This is the new version of the request_header_add patch. It is a little
>> bigger than the original it make many changes, but I hope it is OK and
>> did not add bugs to squid.
>>
>> This patch:
>> - The format/* interface used to format added headers.
>> - The logformat codes used for request_header_add option
>> - Add the new %ssl::>cert_subject and %ssl::>cert_issuer log formating
>> codes
>> - The request_header_add project has as requirements login,client ip
>> address and the server name. The %ul, %>a and %{Host}>h can be used with
>> this patch.
>> - AccessLogEntry is a RefCountable class in this patch.
>>
>> I hope it is OK.
>
>
> +1. Looks okay to me.
>
> Would you be able to commit the AccessLogEntry and libformat changes
> separate from the header mangling please. I'm happy for both to go in at
> once though.
>
> Amos
>
>
Received on Tue Jul 17 2012 - 14:34:42 MDT
This archive was generated by hypermail 2.2.0 : Tue Jul 17 2012 - 12:00:03 MDT