Re: [PATCH] Add request_header_add option and [request|reply]_header_* manglers fixes

On 07/06/2012 10:13 AM, Tsantilas Christos wrote:
> On 07/06/2012 05:55 PM, Alex Rousskov wrote:
>> Can we add a link from HttpRequest to the corresponding ClientHttpRequest?
>
> Probably yes. We are creating the HttpRequest inside
> clientProcessRequest function (client_side.cc file). We can link it here.
> We may not be able to link it in some cases where we are creating fake
> HttpRequest objects (httpsEstablish function)

Do you prefer to link/refcount ALEs then, as discussed below?

>> Or is it better to add a link from HttpRequest to AccessLogEntry?
>
> We need to convert AccessLogEntry to cbdata class or use RefCounts to
> use link to AccessLogEntry.

An ALE object will never be invalidated but may be shared so RefCounting
is the right model for it.

Thank you,

Alex.
Received on Sat Jul 07 2012 - 03:28:46 MDT