Re: [PATCH] StatHist refactoring interim merge, proposed fix for bug 3381

From: Kinkie <gkinkie_at_gmail.com>
Date: Mon, 9 Jan 2012 20:45:58 +0100

> Do we use StatHist::operator "=="? If not, I suggest not adding it
> because the added code may return false for histograms that are
> essentially the same for many practical purposes. In general, what
> histograms are considered the same depends on the caller use of
> statistics so if we do not have any callers, let's not add this code.
>
> No need to repost the patch with this minor change, of course.

It is only used in the unit tests.
I can remove that if you feel that'd be better. I don't know how to
meaningfully perform unit testing without adding to the class'
interface, as it has virtually no useable accessors.

-- 
    /kinkie
Received on Mon Jan 09 2012 - 19:46:06 MST

This archive was generated by hypermail 2.2.0 : Tue Jan 10 2012 - 12:00:04 MST