Re: [PATCH] Bug 3150: do not start useless unlinkd.

Hi all.

There has been no discussion on this thread for a while. The latest
patch version (attached) fixes all the issues from Amos and Alex I know
of. So I would like to get an approval for the patch or hints at what
else needs to be fixed.

The patch does not change the way unlinkd is started. But after the
changes, unlinkd is started iff it is needed. Whether unlinkd is needed
is determined by both cache dir and DiskIO strategy. Unlinkd may be
started during reconfiguration if a cache dir that needs it was added or
DiskIO strategy changed.

There was discussion about starting unlinkd on demand. But the
consensus seems to be that it Squid needs substantial changes to
minimize fork() performance penalty. So while we want to implement this
long term, for now we should start unlinkd on startup and
reconfiguration.

Please let me know if I missed any comments or issues with the patch.

Regards,
  Dmitry