Re: [PATCH] Delete server-side deleteThis()

If there is not any objection I will commit this patch to trunk

On 10/13/2011 10:32 PM, Tsantilas Christos wrote:
> A new version of the patch.
>
> On 10/13/2011 02:55 PM, Amos Jeffries wrote:
>> On 13/10/11 22:02, Tsantilas Christos wrote:
>>> This patch finishes the conversion of ServerStateData into AsyncJob by
>>> properly implementing the doneAll() method and by removing calls to
>>> deleteThis() or replacing with mustStop() calls as appropriate.
>>>
>>> Also the Adaptation::AccessCheck modified to schedule an AsyncJobCall
>>> when access check finishes.
>>>
>>> ServerStateData and ClientHttpRequest classes modified to work with the
>>> new Adaptation::AccessCheck.
>>>
>>>
>>> This is a Measurement Factory project
>>
>> Thanks. That looks a lot cleaner :)
>>
>>
>> Please Scan for ';;' typos though.
>
> Should be OK now.
>
>>
>>
>> In http.cc:
>> * please also drop the dead httpStateFree(), it is completely wrong now.
>
> done.
>
>>
>>
>> In the new doneAll() you seem to have dropped:
>> -#if USE_ADAPTATION
>> - Adaptation::Initiator::doneAll() &&
>> - BodyProducer::doneAll() &&
>> -#endif
>> - BodyConsumer::doneAll()
>>
>> ... IIRC that goes against the AsynJob API requirements. If it is
>> supposed to be dropped please add a comment about why.
>
> I put back these doneAll() methods as Alex suggested.
>
>
>
>>
>>
>> Amos
Received on Fri Oct 21 2011 - 14:06:36 MDT