Re: [PATCH] Delete server-side deleteThis()

On 10/13/2011 01:32 PM, Tsantilas Christos wrote:
> A new version of the patch.
>
> On 10/13/2011 02:55 PM, Amos Jeffries wrote:
>> Please Scan for ';;' typos though.
>
> Should be OK now.
>
>>
>>
>> In http.cc:
>> * please also drop the dead httpStateFree(), it is completely wrong now.
>
> done.
>
>>
>>
>> In the new doneAll() you seem to have dropped:
>> -#if USE_ADAPTATION
>> - Adaptation::Initiator::doneAll() &&
>> - BodyProducer::doneAll() &&
>> -#endif
>> - BodyConsumer::doneAll()
>>
>> ... IIRC that goes against the AsynJob API requirements. If it is
>> supposed to be dropped please add a comment about why.
>
> I put back these doneAll() methods as Alex suggested.

Looks good to me. I like how this patch actually decreases the number of
source code lines :-).

Thank you,

Alex.
Received on Fri Oct 14 2011 - 01:32:04 MDT