Re: [PATCH] Delete server-side deleteThis()

On 13/10/11 22:02, Tsantilas Christos wrote:
> This patch finishes the conversion of ServerStateData into AsyncJob by
> properly implementing the doneAll() method and by removing calls to
> deleteThis() or replacing with mustStop() calls as appropriate.
>
> Also the Adaptation::AccessCheck modified to schedule an AsyncJobCall
> when access check finishes.
>
> ServerStateData and ClientHttpRequest classes modified to work with the
> new Adaptation::AccessCheck.
>
>
> This is a Measurement Factory project

Thanks. That looks a lot cleaner :)

Please Scan for ';;' typos though.

In http.cc:
  * please also drop the dead httpStateFree(), it is completely wrong now.

In the new doneAll() you seem to have dropped:
-#if USE_ADAPTATION
- Adaptation::Initiator::doneAll() &&
- BodyProducer::doneAll() &&
-#endif
- BodyConsumer::doneAll()

... IIRC that goes against the AsynJob API requirements. If it is
supposed to be dropped please add a comment about why.

Amos

-- 
Please be using
   Current Stable Squid 2.7.STABLE9 or 3.1.15
   Beta testers wanted for 3.2.0.12