Re: [PATCH] Bug 3349: Bad support for adaptation service URIs with '='

 On Wed, 05 Oct 2011 11:32:39 +0300, Tsantilas Christos wrote:
> Currently using URIs which include "=" is not supported by
> ecap_service/icap_service configuration parameters. Also the
> squid.conf
> documentation about ecap_service is outdated.
>
> This patch
> - Fixes the [e|i]cap_service line parser to allow URIs with "="
> - Changes the [e|i]cap_service configuration parameter to use the
> following syntax:
> ecap_service id vectoring_point uri [name=value ...]
> - Check for duplicated options
> - Fixes the related documentation
> - Also the older [e|i]cap_service syntax forms are supported:
> ecap_service id vectoring_point [1|0] uri
> ecap_service id vectoring_point [name=value ...] uri
> - The "uri" options is not documented but supported.
>
> This is a Measurement Factory project.

 Since you alter the way the 0/1 backward compatibility is parsed please
 take the opportunity to add a debugs() "UPGRADE: " message at level
 "(opt_parse_cfg_only?0:1)" to the cases. Stating that option format has
 changed and what it should be upgraded to.

 In the duplicate warning message:
  - s/Douplicate/Duplicate/
  - s/ataptation/adaptation/

 Amos
Received on Wed Oct 05 2011 - 21:51:22 MDT