Re: [PATCH] %>la for intercepted connections

On 29/08/11 06:39, Tsantilas Christos wrote:
> On 08/27/2011 08:03 PM, Amos Jeffries wrote:
>> On 28/08/11 02:50, Tsantilas Christos wrote:
>>> %>la for intercepted connections
>>>
>>> This patch adjusts the %>la logformat code handling for intercepted
>>> connections
>>> based on the following rules:
>>> - If the corresponding http_port or https_port option has an explicit
>>> listening host name or IP address, then log the IP address.
>>> - Otherwise, log a dash character.
>>>
>>> Also adjusts %>lp logformat code handling for intercepted connections to
>>> always
>>> log the port number from the corresponding http_port or https_port
>>> option.
>>
>> +1. Looks fine.
>>
>> Amos
>
> I will commit this patch to trunk if there is not any objection.
>
>
> PS. I forgot to mention that this is a Measurement Factory project.

This whole thing itches a worry in the back of my mind. Updating the
release notes about %>la creation today makes me realize what it is.

  We are using ">" on tags to indicate incoming things, usually state
shared with the clients view of the world. This change makes the tag
loose that overlap with the clients world view on intercepted traffic.

What do you think about resurrecting %la / %lp for this data instead?

Amos

-- 
Please be using
   Current Stable Squid 2.7.STABLE9 or 3.1.15
   Beta testers wanted for 3.2.0.10