Re: [PATCH] Add DNS lookup step to ICAP connect

My sense is that the commSetTimeout/comm_add_close_handler calls should
moved from the Adaptation::Icap::Xaction::dnsLookupDone to the
Adaptation::Icap::Xaction::noteCommConnected method.

On 06/29/2011 01:32 PM, Tsantilas Christos wrote:
> On 06/28/2011 04:27 PM, Amos Jeffries wrote:
>> Any feedback? yay/nay/garbage
>>
>> Amos
>
> I am still having problems:
> assertion failed: comm.cc:749: "fd >= 0"
>
>
> backtrace:
> #0 0x00007f55b8189a75 in *__GI_raise (sig=<value optimized out>)
> at ../nptl/sysdeps/unix/sysv/linux/raise.c:64
> #1 0x00007f55b818d5c0 in *__GI_abort () at abort.c:92
> #2 0x0000000000512465 in xassert (msg=0x1ed0 <Address 0x1ed0 out of
> bounds>,
> file=0x208be20 "\230NM\270U\177", line=749) at debug.cc:567
> #3 0x0000000000609ca0 in commSetTimeout (fd=-1, timeout=30, callback=...)
> at comm.cc:749
> #4 0x000000000069d53b in Adaptation::Icap::Xaction::dnsLookupDone (
> this=0x206aef8, ia=<value optimized out>) at Xaction.cc:176
> #5 0x00000000005767e6 in ipcache_nbgethostbyname (
> name=0x1c75ce0 "192.168.1.2", handler=0x69e070 <icapLookupDnsResults>,
> handlerData=0x206aef8) at ipcache.cc:658
> #6 0x000000000069f9dd in Adaptation::Icap::Xaction::openConnection (
> this=0x206aef8) at Xaction.cc:136
> #7 0x0000000000606b94 in JobDialer<AsyncJob>::dial(AsyncCall&) ()
> #8 0x00000000006044e9 in AsyncCall::make (this=0x206bb90) at
> AsyncCall.cc:36
> #9 0x000000000060712b in AsyncCallQueue::fireNext (this=<value optimized
> out>)
> at AsyncCallQueue.cc:54
> #10 0x00000000006072c0 in AsyncCallQueue::fire (this=0x1cd5a80)
> at AsyncCallQueue.cc:40
> #11 0x000000000052004c in EventLoop::runOnce (this=0x7fff17a42a40)
> at EventLoop.cc:131
> #12 0x0000000000520128 in EventLoop::run (this=0x7fff17a42a40)
> at EventLoop.cc:95
> #13 0x0000000000579825 in SquidMain (argc=<value optimized out>,
> argv=0x7fff17a42c08) at main.cc:1506
> #14 0x000000000057a026 in SquidMainSafe (argc=7888, argv=0x1ed0)
>
>
Received on Wed Jun 29 2011 - 11:23:55 MDT