Re: [PATCH] URL logformat codes %<ru and %>ru

On 05/18/2011 08:52 AM, Amos Jeffries wrote:
> This patch adds the logging codes:
> %>ru - Request URL from the client original request.
> %<ru - Request URL sent to the server.

It also fixes or changes %rp behavior to use adapted URI, if any. Please
mention that in the commit message if that fix (or change) is
intentional. If the change makes %rp always behave like %<rp (path sent
to the server), perhaps squid.conf should be updated accordingly as well?

> Ideally these will log the original syntax, but Squid does not preserve
> that. For now the canonical URI are used instead.
>
> The %ru is retained to display the same old historic logging URL it used
> to. This appears to be the client original in most cases, but has been
> observed with different content to both the canonical client URL and
> canonical server URL in some cases.

Perhaps we should leave %rp to have the same inconsistent behavior as
%ru then? It is kind of wrong if the two get out of sync. Adding %<rp
and %>rp would be fine, of course.

Thank you,

Alex.

> These are desired so as to be able to log and identify the actual
> outgoing URLs in relation to what is incoming.
>
>
> This depends on bug fixes to re-write cloning and URL handling in the
> accompanying patch.
>
> Amos
Received on Wed May 18 2011 - 16:04:33 MDT