On 01/04/11 09:36, Kinkie wrote:
>> I left the "if (true)" guard to prevent indentation changes to the
>> pretty long logRequest method, making the patch more difficult to
>> understand. I will remove that otherwise useless guard during commit
>> unless you think it should stay.
>
> +1, with the suggestion of possibly making the debugs() statement have
> a lower priority (that is, make it harder to print).
+ and ditto on the debugs. 5 maybe 6for that IMO.
And yes, please remove the if (true) and run the
scripts/sourcemaintenance.sh over it before commit.
Amos
-- Please be using Current Stable Squid 2.7.STABLE9 or 3.1.11 Beta testers wanted for 3.2.0.5Received on Thu Mar 31 2011 - 23:00:01 MDT
This archive was generated by hypermail 2.2.0 : Fri Apr 01 2011 - 12:00:05 MDT