Re: [RFC] straightening out unit-test dependencies

On 22/02/11 14:17, Alex Rousskov wrote:
> On 02/18/2011 12:56 AM, Amos Jeffries wrote:
>> During the shuffling work for SourceLayout I keep running headlong into
>> the few remaining unit tests which include nearly all of the squid
>> sources due to legacy design.
>>
>> This is further hampered by the fact that the worst ones appear short
>> but make use of nested $() sub-list includes. So not only do they have
>> dependency on the .cc files but on the .cc files incuded by otehr unit
>> tests as well.
>>
>> Does anyone object to a patch which unwinds these nested $() lists and
>> makes the remaining messy unit tests include their full minimal list of
>> .cc directly?
>
> FWIW, I cannot object to anything you think will fix test cases! We all
> know how much time is often wasted on trying to make them work again
> after moving a few misplaced code lines.
>
> I am sure there are useful cases somewhere, but I wonder whether the net
> result has been positive so far (rhetorical). I would not object to
> removing or disabling poorly written cases either.
>
>
> Thank you,
>
> Alex.

For the record this is now done. rev11276

Amos

-- 
Please be using
   Current Stable Squid 2.7.STABLE9 or 3.1.11
   Beta testers wanted for 3.2.0.5