Re: [PATCH] SMP Cache manager: add support for parameterized Cache Manager queries

 On Tue, 01 Mar 2011 16:28:47 -0700, Alex Rousskov wrote:
> On 03/01/2011 11:29 AM, Tsantilas Christos wrote:
>> Any comment on this forgotten patch?
>
> Hi Christos,
>
> If you do not have doubts about the changes, please feel free to
> commit them after nobody reviews them for two weeks. We do not have
> enough folks to guarantee that every single patch will be reviewed,
> and
> it is bad for everybody when the good code gets stuck. This is why
> Squid
> wiki says:
>
> 4. Submissions older than 10 days without negative votes are
> accepted.
>
> As for the patch itself, the functionality is needed in SMP
> deployments,
> and I cannot think of a better URL format for queries because it is
> based on the existing CGI standard, easy enough to read/type, and
> will
> work well with Cache Manager HTML wrappers.
>
> The only problem with the CGI format, IMO, is that question mark and
> ampersand are special to the shell, but it is not that difficult to
> quote the URL. If somebody wants to also support shell-safe markup
> (e.g., treat the first '/' as '?' and other '/' as '&'), we can
> always
> discuss and add such support later.

 I'm against doing such custom tricks. They add complexity and confusion
 for little or no gain. All other CLI tools require the user or script to
 perform relevant CLI-wrappings of special shell characters.

 I gave the patch a brief look over earlier when it was submitted and do
 not recall seeing anything major. Please check that it still builds
 cleanly before commit, but that is all.

 I'm kind of in favour of restricting it to the "process=" parameter,
 instead of two with an overlap.
 Since we give each process a pseudo-unique procID this makes more sense
 and is wider in its support of the planned helper/worker/kid types.

 Amos
Received on Tue Mar 01 2011 - 23:57:49 MST