Re: /bzr/squid3/trunk/ r11133: Compat: static functions cannot be passed externally

From: Amos Jeffries <squid3_at_treenet.co.nz>
Date: Fri, 17 Dec 2010 14:29:40 +1300

On 17/12/10 04:14, Henrik Nordström wrote:
> fre 2010-12-17 klockan 01:38 +1300 skrev Amos Jeffries:
>
>> Apparently old GCC (dont care), HPUX and Solaris (do care) all complain
>> about it.
>> According to some C++ discussions they are wrong, but it does not hurt
>> to remove these for now and save on using a bunch of hacks.
>
> I would not call static functions a hack, static vs global is just
> another namespace tuning tool, but fine.

no, no. I don't mean the static was a hack, but figuring out where it
was usable and where not is. To keep it we have to add many repetitions
of this:

#if _SQUID_SOLARIS_ && !defined(__GNUC_) || _SQUID_HPUX_ && defined(__GNUC_)
// compiler wont accept static
#else
static
#endif

Amos

-- 
Please be using
   Current Stable Squid 2.7.STABLE9 or 3.1.9
   Beta testers wanted for 3.2.0.3
Received on Fri Dec 17 2010 - 01:29:48 MST

This archive was generated by hypermail 2.2.0 : Fri Dec 17 2010 - 12:00:05 MST