Re: [PATCH] 3.2/3.HEAD: send HTTP/1.1 on CONNECT responses

On 26/11/10 13:51, Amos Jeffries wrote:
> On 26/11/10 13:08, Henrik Nordström wrote:
>> tis 2010-11-23 klockan 03:49 +0000 skrev Amos Jeffries:
>>> 3.2 and later send HTTP/1.1 version on all regular response lines.
>>>
>>> CONNECT seems to have been missed somehow. This corrects the omission so
>>> the hard-coded CONNECT reply strings send 1.1 as well.
>>
>> Ouch, is that response hardcoded?
>
> Yes. In ICAP and in Tunnel.

Sorry, SslBump and Tunnel. (not ICAP).

>
>>
>>> I'm not certain, but this may explain some of the very rare CONNECT
>>> problems seen in 3.2+.
>>
>> Like?
>
> I found a customers Chrome doing several requests then dying very
> consistently on a google HTTPS search.
>
> Changing to 1.1 made it less consistent in its dying. Still happens
> *mostly* so there is more going on. With this bug as just one of the
> side factors.
>
>>
>>> if its not too much trouble could you add this to the compliance testing
>>> queue to see if it fixes/breaks anything before it gets committed
>>> please?
>>
>> It's a trivial change, not much it can break.
>>
>> But even with the change it's a non-compliant response. Should minimally
>> include Date and preferably Server as well.
>
> Amos

Patch applied.

Amos

-- 
Please be using
   Current Stable Squid 2.7.STABLE9 or 3.1.9
   Beta testers wanted for 3.2.0.3