[PATCH] Policy Enforcement: config.h or squid.h includes

From: Amos Jeffries <squid3_at_treenet.co.nz>
Date: Sun, 07 Nov 2010 14:49:40 +1300

We currently have a policy that config.h MUST be included first so as to
pull in the portability definitions early. It MAY be included via the
legacy squid.h at present.

This alteration to the source maintenance script validates that each .c
and .cc file in the sources includes config.h or squid.h first in its
include order.

  * an ERROR: line is produces for each violating file
  * as yet the maintenance run is not blocked so as to catch as many
errors as possible in one run.
  * as yet there are no related code alterations performed by this
script. It only validates.
  * trace FORMAT: informative lines are silenced to make ERROR: more
visible.

Unless there are objections I'll commit immediately.

(see other Cleanup patch for fixes of the problems this already detects).

Amos

Received on Sun Nov 07 2010 - 01:49:45 MST

This archive was generated by hypermail 2.2.0 : Tue Nov 09 2010 - 12:00:04 MST