Re: DIFF: helpers/external_acl/eDirectory_userip

On 19/09/10 15:21, Amos Jeffries wrote:
> On 08/09/10 07:27, Chad Naugle wrote:
>> Necessary patch for making this helper/feature build-able, and compiled
>> into a single file. Further recommended changes will come after this
>> step, such as inet_pton conversion.
>
> Applied. Thank you.
>
> I've been doing static code analysis tests today and fixing memory leaks.
>

meh. mailer troubles.

Here is a list of the important ones the tests have found in this code
(bracket holds the line number):

[214]: (style) After a strncpy() the buffer should be zero-terminated
[216]: (possible error) Dangerous usage of strncat. Tip: the 3rd
parameter means maximum number of characters to append
[861]: (style) After a strncpy() the buffer should be zero-terminated
[867]: (possible error) Dangerous usage of strncat. Tip: the 3rd
parameter means maximum number of characters to append
[1133]: (possible error) Dangerous usage of strncat. Tip: the 3rd
parameter means maximum number of characters to append
[1134]: (possible error) Dangerous usage of strncat. Tip: the 3rd
parameter means maximum number of characters to append
[1147]: (possible error) Dangerous usage of strncat. Tip: the 3rd
parameter means maximum number of characters to append
[1162]: (possible error) Dangerous usage of strncat. Tip: the 3rd
parameter means maximum number of characters to append
[1163]: (possible error) Dangerous usage of strncat. Tip: the 3rd
parameter means maximum number of characters to append
[1125]: (possible error) Dangerous usage of strncat. Tip: the 3rd
parameter means maximum number of characters to append
[1129]: (possible error) Dangerous usage of strncat. Tip: the 3rd
parameter means maximum number of characters to append
[1131]: (possible error) Dangerous usage of strncat. Tip: the 3rd
parameter means maximum number of characters to append
[1154]: (possible error) Dangerous usage of strncat. Tip: the 3rd
parameter means maximum number of characters to append
[1158]: (possible error) Dangerous usage of strncat. Tip: the 3rd
parameter means maximum number of characters to append
[1160]: (possible error) Dangerous usage of strncat. Tip: the 3rd
parameter means maximum number of characters to append
[1142]: (possible error) Dangerous usage of strncat. Tip: the 3rd
parameter means maximum number of characters to append
[1145]: (possible error) Dangerous usage of strncat. Tip: the 3rd
parameter means maximum number of characters to append
[1195]: (style) After a strncpy() the buffer should be zero-terminated
[1387]: (style) After a strncpy() the buffer should be zero-terminated
[1389]: (possible error) Dangerous usage of strncat. Tip: the 3rd
parameter means maximum number of characters to append
[1419]: (style) After a strncpy() the buffer should be zero-terminated
[1421]: (possible error) Dangerous usage of strncat. Tip: the 3rd
parameter means maximum number of characters to append
[1451]: (style) After a strncpy() the buffer should be zero-terminated
[1453]: (possible error) Dangerous usage of strncat. Tip: the 3rd
parameter means maximum number of characters to append
[1483]: (style) After a strncpy() the buffer should be zero-terminated
[1485]: (possible error) Dangerous usage of strncat. Tip: the 3rd
parameter means maximum number of characters to append
[1515]: (style) After a strncpy() the buffer should be zero-terminated
[1517]: (possible error) Dangerous usage of strncat. Tip: the 3rd
parameter means maximum number of characters to append
[227]: (error) Undefined behaviour: dbuf is used wrong in call to
sprintf or snprintf. Quote: If copying takes place between objects that
  overlap as a result of a call to sprintf() or snprintf(), the results
are undefined.
[264, 303]: (error) Undefined behaviour: dbuf is used wrong in call to
sprintf or snprintf. Quote: If copying takes place between objects that
  overlap as a result of a call to sprintf() or snprintf(), the results
are undefined.
[303]: (error) Undefined behaviour: dbuf is used wrong in call to
sprintf or snprintf. Quote: If copying takes place between objects that
  overlap as a result of a call to sprintf() or snprintf(), the results
are undefined.

Amos

-- 
Please be using
   Current Stable Squid 2.7.STABLE9 or 3.1.8
   Beta testers wanted for 3.2.0.2