Re: Patch to add netfilter mark support

Thanks for the (very) prompt response (I'm impressed). Replies to other
comments to follow; in the meantime...

> * I find the terminology inconsistent and confusing: outgoing,
> clientside, upstream. No wonder you have to explain the difference
> twice. Unless these are all standard RFC-like terms, please use
> something consistent like fromClient, toClient, fromServer, toServer.
> Others may suggest a better scheme, but this one at least does not
> require constant doc lookups to understand where "out" and "up" is.

Agreed. This confusion is also present in the names of the configuration
parameters: initially I found the current ones confusing (it took me a
while to realise that one was server side and one client side).

At the minute they are tcp_outgoing_tos and clientside_tos. Would there
be any objection to changing the tcp_outgoing_tos to serverside_tos? Or
would you prefer not to break existing squid.conf configurations?

> [Hint: In most cases, you can quickly rename things if you undo a patch,
> change the names in the patch file, and apply the changed patch.]

Thanks for the top tip :)

Andy
Received on Mon Sep 06 2010 - 21:08:57 MDT