Re: some patches

Hi Amos,

some feedback from patch writer (Klaus Singvogel) ;)

1) ia64 patch
squid-beta-3.0-ia64.patch

--- squid-3.0-PRE3-20050715/src/ESIExpression.cc.orig 2005-07-03
17:25:08.000000000 +0200
+++ squid-3.0-PRE3-20050715/src/ESIExpression.cc 2005-08-03
12:17:42.723184827 +0200
@@ -714,6 +714,7 @@
rv.eval = NULL; /* A literal */
rv.valuetype = ESI_EXPR_INVALID;
rv.valuestored = ESI_LITERAL_INVALID;
+ rv.precedence = 1; /* A literal */

if (('0' <= *s && *s <= '9') || *s == '-') {
size_t length = strspn (s, "0123456789.");

info: fix for unitialized var (Random Stack Data)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

2) mem_node_64bit
squid-beta-3.0-mem_node_64bit.patch

--- squid-3.0-PRE3-20051212/src/mem_node.cc.orig 2005-11-02
23:19:22.000000000 +0100
+++ squid-3.0-PRE3-20051212/src/mem_node.cc 2005-12-15
14:42:44.000000000 +0100
@@ -49,7 +49,7 @@
makeMemNodeDataOffset()
{
mem_node *p = 0L;
- return int(ptrdiff_t(&p->data));
+ return long(ptrdiff_t(&p->data));
}

/*

info: its a 64bit fix. a "int" has not same length on any architecture
as a 'pointer'
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

hope this will help
Kind Regards
 Chris

Am 31.08.2010 20:10, schrieb Christian:
> Trying to get more info, but maintainer who created these patches isn't
> at suse anymore.
>
> Am 31.08.2010 17:29, schrieb Amos Jeffries:
>
>> Any other details about what they fix? its not exactly clear.
>>
>> The memory one looks like it could be an important overflow fix, buts
>> it's in an area risky to change without knowing details.
>>
>> Amos
>>
>

-- 
Christian
---------------------------------------------------
Der ultimative shop für Sportbekleidung und Zubehör
http://www.sc24.de
---------------------------------------------------