Re: [PATCH] Add build info tag to squid -v output

Kinkie wrote:
> On Sat, Sep 4, 2010 at 3:25 PM, Amos Jeffries <squid3_at_treenet.co.nz> wrote:
>> Kinkie wrote:
>>> Hi all,
>>> a followup to yesterday's and today's IRC discussion.
>>> This patch adds a configure option --enable-build-info[=text]
>>>
>>> If text is specified, it will print it on the second line of "squid -v".
>>> If the option is given but no text is specified, configure will
>>> attempt to determine whether we are in a bzr checkout and locate the
>>> bzr executable. If both succeed, it will automatically build a text
>>> string containing the branch nickname and revno.
>>> If no option is given, nothing will happen.
>>>
>>> This patch serves two purposes:
>>> - help those who closely trail trunk or some other bzr branch to
>>> easily pinpoint good revisions
>>> - help those who develop custom builds (e.g. for a specific customer)
>>> explicitly mark it as such.
>>>
>> Looks okay for the option itself. Have not had time to check it works, but
>> will assume you have.
>>
>> For the testbed please use tab indentation on the indented lists.
>>
>> Also please follow the levels intentions:
>> * default level leaves unspecified.
>> * minimal level forces --disable
>> * maximal level forces --enable (with any parameter string)
>> * no-deps level forces component --enable with any special requirements
>> forced --without. In this case it could be just forcing --enable-build-info
>> and the bzr auto-detect.
>
> Ok, will do.
>
>> We will have to add a new level that just tests ./configure behaviour
>> instead of full build for the options which alter behaviour when presented
>> with a ="foo" string. That needs a more planning though since only configure
>> is needed there.
>
> Well, four full builds take quite a long time already.. I'd prefer to
> avoid adding more, unless it's really useful.

Yesh, the others do a full distcheck. This one I was thinking limiting
it to only do "./configure $OPTS" then scan autoconf against the
expected output. Like you were doing for your reconf testing.

Amos

-- 
Please be using
   Current Stable Squid 2.7.STABLE9 or 3.1.8
   Beta testers wanted for 3.2.0.2