Re: /bzr/squid3/trunk/ r10691: Bug 2994: pt 2: Open ports as IP4-only when IPv6 disabled

Henrik Nordström wrote:
> sön 2010-08-01 klockan 16:33 +1200 skrev Amos Jeffries:
>
>> + // if IPv6 is split-stack, prefer IPv4
>> + if (Ip::EnableIpv6&IPV6_SPECIAL_SPLITSTACK) {
>> + // NP: This is not a great choice of default,
>> + // but with the current Internet being IPv4-majority has a higher success rate.
>> + // if setting to IPv4 fails we dont care, that just means to use IPv6 outgoing.
>> + outgoing.SetIPv4();
>> + }
>
> Doesn't this break connectivity to IPv6-only hosts?

If they lack v4-mapping stack abilities yes. As noted its not a great
default, but will be passable for the majority.
The v6-only split-stack users can configure up their IPv6
tcp_outgoing_address.

>
> What happened with the comm reoredring moving socket type & outgoing
> address selection down to after the destination address have been
> selected?

Still pending an audit pass. Alex found a lot of problems with my first
implementation(s) and I'm still working on fixing a few FTP issues after
the corrections.

Amos

-- 
Please be using
   Current Stable Squid 2.7.STABLE9 or 3.1.5