Re: /bzr/squid3/trunk/ r10615: Define MSG_NOSIGNAL if it is missing.

On 07/07/2010 05:14 PM, Amos Jeffries wrote:
> On Wed, 07 Jul 2010 11:39:21 -0600, Alex Rousskov
> <rousskov_at_measurement-factory.com> wrote:
>> ------------------------------------------------------------
>> revno: 10615
>> committer: Alex Rousskov <rousskov_at_measurement-factory.com>
>> branch nick: trunk
>> timestamp: Wed 2010-07-07 11:39:21 -0600
>> message:
>> Define MSG_NOSIGNAL if it is missing.
>>
>> Solaris and possibly others do not provide this optional optimization.
>> modified:
>> src/fd.cc
>
> As per your code comment. Yes please use compat/os/solaris.h for these.

But what if other OSes need the same? The MSG_NOSIGNAL defining hack
does not seem to be specific to Solaris.

Also, if I put this into compat/os/solaris.h or compat/*shared*h, it
will suck in sys/types.h and sys/socket.h into every Squid source file,
right? That also does not seem like a good idea...

On the other hand, creating a special compat/uds.h file for just one
tiny hack that is used in only one place also seems like an overkill.

What is the best option here?

Thank you,

Alex.
Received on Thu Jul 08 2010 - 04:37:44 MDT