Re: [PATCH] immortal helpers

mån 2010-02-22 klockan 11:44 +1100 skrev Robert Collins:

> command protocol for it would be pretty similar to the SHM disk IO
> helper, but for processes. Something like:
> squid->helper: spawn stderrfd argv(escaped/encoded to be line & NULLZ
> string safe)
> helper->squid: pid, stdinfd, stdoutfd

Which requires UNIX domain sockets for fd passing, and unknown
implementation on Windows..

> This would permit several interesting things:
> - starting helpers would no longer need massive VM overhead
> - we won't need to worry about vfork, at least for a while
> - starting helpers can be really async from squid core processing (at
> the moment everything gets synchronised)

Yes.

+1 in general, with the reservation that I want to hear back from Guido
on what options there may be on Windows platform.

But I guess all of this can be encapsulated so it doesn't matter.
windows already have a native spawn function if I remember right.

also, the above could also be achieved using posix_spawn() on platforms
having it (or vfork if we want to mess with the gory details, I prefer
not).

The async aspect is mostly unrelated to implementation I would say.

so +0.5 actually...

Regards
Henrik
Received on Mon Feb 22 2010 - 01:03:39 MST