Re: [MERGE] acl support for range_offset_limit

On Wed, 10 Feb 2010 10:39:18 -0500, Matthew Morgan
<atcs.matthew_at_gmail.com>
wrote:
> Here is the patch to add acl support to range_offset_limit. It is being

> parsed using the same data types as reply_body_max_size, which means the

> limit value gets run through parseBytesLine64, and the acl is optional.

> If people are using the old global style of range_offset_limit, they
> shouldn't have to do anything to their configs.
>
> As per Amos' request, getRangeOffsetLimit is now a member of
> HttpRequest, and it caches it's value the same way reply_body_max_size
> does.
>
> Sorry it has taken me so long! Thanks for being patient.

Thank you. Looks good now.

There are just some doc and polish bits, but I can do that during merge...

 * typedefs.h and cf.data.depend changes appear to be unused now and can
be dropped.

 * use of "none" in cf.data.pre documentation instead of -1 to indicate
the limit is removed and always download entire object.

 * mention in cf.data.pre that if units is omitted Bytes will be assumed.

Amos
Received on Thu Feb 11 2010 - 02:34:38 MST