Re: [PATCH] Interpreted Range memory leak (3.0 only)

From: Amos Jeffries <squid3_at_treenet.co.nz>
Date: Fri, 05 Feb 2010 11:01:47 +1300

Alex Rousskov wrote:
> Prevent memory leaks when interpreting Range requests.
>
> HttpRequest::range field could be set to a new HttpHdrRange object
> twice: once in clientInterpretRequestHeaders() and once in
> HttpRequest::hdrCacheInit() called from HttpRequest::parseHeader().
>
> HttpRequest::range field could be cleared without destroying
> HttpHdrRange object in clientInterpretRequestHeaders().
>
> The range field is essentially a cached value of the parsed Range
> header. Managing the cache outside its owner object is a bad idea.
>

+1.

Amos

-- 
Please be using
   Current Stable Squid 2.7.STABLE7 or 3.0.STABLE23
   Current Beta Squid 3.1.0.16
Received on Thu Feb 04 2010 - 22:02:00 MST

This archive was generated by hypermail 2.2.0 : Fri Feb 05 2010 - 12:00:06 MST