Re: Valgrind results

Henrik Nordstrom wrote:
> On Tue, 2008-03-25 at 10:23 +1300, Amos Jeffries wrote:
>
>> I found that in 3.x as well. It turns out those bits of valgrind code
>> only occur if both --enable-leakfinder and --with-valgrind-debug are
>> enabled.
>>
>> My test script only had "--with-valgrind" which wasn't doing even the
>> job it needed to :-(
>
> Odd..

Twas until I realised it changed in -3 to have a "-debugs" or somesuch
on the end. My scripts were still using the -2 option :-(

>
>> FWIW: Is there any reason why we need separate leakfinder and valgrind
>> modes?
>
> valgrind should implicitly enable leakfinder I think. The leakfinder
> code is independent from valgrind however.
>
> And additionally the code fragment discussed should not even depend on
> leakfinder, only valgrind..

Okay. I'll fix that then.

Amos

-- 
Please use Squid 2.6STABLE17+ or 3.0STABLE1+
There are serious security advisories out on all earlier releases.