Re: two xasserts in squid3

>
> On Tue, 2008-02-12 at 11:10 +1300, Amos Jeffries wrote:
>> > On Mon, 2008-02-11 at 09:33 +1100, Robert Collins wrote:
>> >> One of the things I'd most love to see is the modularisation
>> completed
>> >> - complete deletion of protos.h, structs.h, typedefs.h.
>> >
>> > Yes, of course. That would be the focus of the cleanup that Amos is
>> > volunteering to do :-)
>> >
>>
>> Hows this for an action plan Robert?
>>
>> * Obsolete typedefs.h (underway)
>> - remove all unneeded typedefs
>> - move all needed typedefs to their appropriate headers
>> - fix compile errors
>>
>> * Add automatic testing for header dependency
>> - script to perform universal include unit-test for .h files
>> - link to automatic unit-testing in each directory
>> - fix the compile errors!
>>
>> * Obsolete protos.h
>> - move all protos to their appropriate header files
>> - add includes for headers where needed.
>>
>> * Obsolete structs.h
>> - move all structs to their appropriate header files
>> - move modular configuration in to *Config.h files
>> (discussion on exactly what the modules are)
>
> I like the automatic include unit test. I found while slowly working
> through this that circular structure dependencies made it quite tricky;

Yes found that already, and have not even started. ;-)
I can't believe I'm thankful that many of them use pointer-fields.

> I think you will find you need
>
> * Break dependencies

Please explain. I assume you mean the "class Something;" pre-definitions
instead of #includes.

>
> to make it really clean, but that can be longer term if needed.
>
> -Rob
> --
> GPG key available at: <http://www.robertcollins.net/keys.txt>.
>
Received on Mon Feb 11 2008 - 16:08:14 MST