Re: httpProcessReplyHeader question

On Tue, 2007-02-13 at 19:45 +0800, Adrian Chadd wrote:
> There's this in httpProcessReplyHeader:
>
> hdr_size = headersEnd(httpState->reply_hdr.buf, hdr_len);
> if (hdr_size)
> hdr_len = hdr_size;
> if (hdr_len > Config.maxReplyHeaderSize) {
> debug(11, 1) ("httpProcessReplyHeader: Too large reply header\n");
> /* [ahc] XXX not sure how to handle this and we should think about it; so fail out for now */
> storeAppend(entry, httpState->reply_hdr.buf, httpState->reply_hdr.size);
> memBufClean(&httpState->reply_hdr);
> reply->sline.status = HTTP_HEADER_TOO_LARGE;
> httpState->reply_hdr_state += 2;
> ctx_exit(ctx);
> return size;
> }
>
>
> Why is there a storeAppend with no http parse?

Could it be because the header is so large that it was considered
dangerous or even impossible to parse when the above code was written?

Alex.
Received on Tue Feb 13 2007 - 08:08:21 MST