Re: [Squid-cvs] squid3-ipv6 squid3/src ACLIP.cc,1.8.2.4,1.8.2.5

From: Henrik Nordstrom <hno@dont-contact.us>
Date: Thu, 26 May 2005 00:10:52 +0200 (CEST)

On Wed, 25 May 2005, Rafael Martinez Torres wrote:

> Index: ACLIP.cc
> - if (ntohl(A.s_addr) > ntohl(C.s_addr))
> + if (memcmp(&A, &C, sizeof(struct IN_ADDR)) >0)

Hmm.. this has quite different semantics. The original looks at the
addresses in host byte order, while the memcmp looks at the addresses in
network byte order...

are you sure this change is OK here?

Regards
Henrik
Received on Wed May 25 2005 - 16:10:54 MDT

This archive was generated by hypermail pre-2.1.9 : Tue May 31 2005 - 12:00:03 MDT